feat(ssh): add ssh tunnel support for the docker image #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empwilli
changed the title
JanZachmann
requested changes
Apr 8, 2024
empwilli
force-pushed
the
feat/ssh_tunnel_docker_support
branch
2 times, most recently
from
bebcc9a
to
1ddb7d5
Compare
JanZachmann
approved these changes
Apr 8, 2024
JoergZeidler
reviewed
Apr 8, 2024
JoergZeidler
reviewed
Apr 8, 2024
JoergZeidler
approved these changes
Apr 10, 2024
When running the omnect-cli from within a containerized environment, authentication will not work out of the box: when binding to localhost, the client will bind to localhost from inside of the container, it is not possible to connect from the container externally. This adds a check for the "CONTAINERIZED" environment variable. If this environment variable is set, the auth redirect server will instead bind to "0.0.0.0", the idea being, that docker can do the mapping to local host, then. Furthermore, we add the "CONTAINER_HOST" variable which allows the omnect-cli to determine the host system so that an according ssh config can be generated.
empwilli
force-pushed
the
feat/ssh_tunnel_docker_support
branch
from
365ff61
to
43a34f0
Compare
|
Had to rebase on main. |
JoergZeidler
approved these changes
Apr 11, 2024
JanZachmann
approved these changes
Apr 11, 2024
This adds the necessary environment variable setting for running omnect-cli on a Windows host.
JoergZeidler
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running omnect-cli in a docker container, we need some extra steps to get the ssh tunnel feature to work. Furthermore, when running on windows host systems we have to make some adjustments in the ssh configuration.
This PR extends the omnect-cli so that we can pass the setup (containerized or not, windows host) in via environment variables and to generate an according configuration.
Furthermore, this extends the documentation to include the necessary steps to run the omnect-cli in a containerized environment.