Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use watcher's /deposits.all endpoint to fetch past deposits #91

Open
Pongch opened this issue Jul 20, 2020 · 0 comments
Open

use watcher's /deposits.all endpoint to fetch past deposits #91

Pongch opened this issue Jul 20, 2020 · 0 comments

Comments

@Pongch
Copy link
Contributor

Pongch commented Jul 20, 2020

web-wallet should use watcher's endpoint to fetch all the confirmed deposits instead of calling Ethereum node.

As for the unconfirmed deposits (deposits not yet seen by Watcher passed the configured block confirmations), the web-wallet could look only for pending statuses from Ethereum node.

ie. wallet call Eth node for deposits between
web3.eth.isSyncing().currentBlockHeight - services_synced_heights.depositor as opposed to searching from the genesis block/block 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pongch