Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check the deployed contracts are with expected configs/args/params #663

Open
boolafish opened this issue Jul 22, 2020 · 0 comments
Open

Comments

@boolafish
Copy link
Contributor

boolafish commented Jul 22, 2020

Issue Type

[ ] bug report
[x] feature request

Current Behavior

No check after contract deployment

Expected Behavior

Have the check to validate what we deploy is what we expect

Motivation for Change

There was discussion in the effort of moving PaymentExitGame constructor to an init function. Should that function being guarded by maintainer. There is the risk somebody aside from our deployment script could pass in the params before we do that and lead to a wrong contract deployment.

With this, we would immediately know this set of deployed contracts cannot be used.

Sth outside of contract could be like checking authority address nonce.

This might be sth good to have no matter our deployment script would have the concern or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant