Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add BaseMainWindowMenuHandler abstract class #975

Closed
wants to merge 2 commits into from
Closed

refactor: Add BaseMainWindowMenuHandler abstract class #975

wants to merge 2 commits into from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Mar 9, 2024

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Bug fix -> [bug]
  • Feature enhancement -> [enhancement]
  • Documentation -> [documentation]
  • Build and release changes -> [build/release]
  • Other (describe below)

Which ticket is resolved?

  • Title ex. fix...

    • URL ex. https://...

  • Title

    • URL

What does this PR change?

Other information

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/2cd5rl5qkygxm

@miurahr miurahr force-pushed the topic/miurahr/refactor/gui/base-main-window-menu-handler branch from 8b35bae to 210b26d Compare March 9, 2024 07:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/kroqk36dbei2q

@miurahr
wip
1f52b32 
Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/cj45t37iho6vy

@miurahr
Copy link
Member Author

miurahr commented Mar 20, 2024 •
edited
Loading

#983 is a successor of here.

There are several issues not addressed in #983 but touched here.
I keep here as draft and check it after #983 merged,

@miurahr
Copy link
Member Author

miurahr commented May 3, 2024

Close here because we have successor topic branch.

@miurahr miurahr closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miurahr