Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CLI exit codes #267

Open
joshmoore opened this issue Oct 21, 2020 · 2 comments
Open

Unify CLI exit codes #267

joshmoore opened this issue Oct 21, 2020 · 2 comments

Comments

@joshmoore
Copy link
Member

joshmoore commented Oct 21, 2020

The exit codes used throughout the CLI plugins are assigned randomly. Though it would be a breaking change, it would be useful to define a much smaller number of codes that users can expect.

see:

options:

Additionally as seen in ome/openmicroscopy#6003 (comment) values should be reduced to less than 256.

@manics
Copy link
Member

manics commented Oct 21, 2020

A starting point (and non-breaking change) could be a top-level enum that defines ALL allowed error codes in omero-py? i.e. an omero version of the Python errno module. <Edit actually ready your description properly now and you've already said this :-) >

@joshmoore
Copy link
Member Author

I'd think that'd be a good addition, but I imagine plugins will need the ability to add. (i.e. not an enum but a registry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants