[TASK] Move the repository unit tests to functional

This saves us the work of instantiating the repositories and their dependencies ourselves in the tests.
oliverklee · Oct 3, 2024 · af7d53d · af7d53d
1 parent e38fcd1
commit af7d53d
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 114 deletions.
diff --git a/Tests/Functional/Domain/Repository/FrontendUserGroupRepositoryTest.php b/Tests/Functional/Domain/Repository/FrontendUserGroupRepositoryTest.php
@@ -5,8 +5,11 @@
 namespace OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Repository;
 
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
+use OliverKlee\FeUserExtraFields\Domain\Repository\DirectPersistInterface;
 use OliverKlee\FeUserExtraFields\Domain\Repository\FrontendUserGroupRepository;
 use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
+use TYPO3\CMS\Extbase\Persistence\Repository;
+use TYPO3\CMS\Extbase\Persistence\RepositoryInterface;
 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
 
 /**
@@ -26,6 +29,30 @@ protected function setUp(): void
         $this->subject = $this->get(FrontendUserGroupRepository::class);
     }
 
+    /**
+     * @test
+     */
+    public function implementsRepositoryInterface(): void
+    {
+        self::assertInstanceOf(RepositoryInterface::class, $this->subject);
+    }
+
+    /**
+     * @test
+     */
+    public function isRepository(): void
+    {
+        self::assertInstanceOf(Repository::class, $this->subject);
+    }
+
+    /**
+     * @test
+     */
+    public function implementsDirectPersistInterface(): void
+    {
+        self::assertInstanceOf(DirectPersistInterface::class, $this->subject);
+    }
+
     /**
      * @test
      */

diff --git a/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php b/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php
@@ -7,10 +7,13 @@
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUser;
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
 use OliverKlee\FeUserExtraFields\Domain\Model\Gender;
+use OliverKlee\FeUserExtraFields\Domain\Repository\DirectPersistInterface;
 use OliverKlee\FeUserExtraFields\Domain\Repository\FrontendUserRepository;
 use TYPO3\CMS\Extbase\Domain\Model\FileReference;
 use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
 use TYPO3\CMS\Extbase\Persistence\PersistenceManagerInterface;
+use TYPO3\CMS\Extbase\Persistence\Repository;
+use TYPO3\CMS\Extbase\Persistence\RepositoryInterface;
 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
 
 /**
@@ -34,6 +37,30 @@ protected function setUp(): void
         $this->subject = $this->get(FrontendUserRepository::class);
     }
 
+    /**
+     * @test
+     */
+    public function implementsRepositoryInterface(): void
+    {
+        self::assertInstanceOf(RepositoryInterface::class, $this->subject);
+    }
+
+    /**
+     * @test
+     */
+    public function isRepository(): void
+    {
+        self::assertInstanceOf(Repository::class, $this->subject);
+    }
+
+    /**
+     * @test
+     */
+    public function implementsDirectPersistInterface(): void
+    {
+        self::assertInstanceOf(DirectPersistInterface::class, $this->subject);
+    }
+
     /**
      * @test
      */

diff --git a/Tests/Unit/Domain/Repository/FrontendUserGroupRepositoryTest.php b/Tests/Unit/Domain/Repository/FrontendUserGroupRepositoryTest.php
diff --git a/Tests/Unit/Domain/Repository/FrontendUserRepositoryTest.php b/Tests/Unit/Domain/Repository/FrontendUserRepositoryTest.php