Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to fix some message formatting #6145

Merged
merged 5 commits into from
Oct 27, 2024

Conversation

DayV-git
Copy link
Contributor

Description:

Working on fixing the grammar / incorrect punctuation in bot messages. First step is defining a function that creates X, Y or Z and X, Y and Z strings instead of X, Y, Z. Implemented and added in a handful of places. If accepted, further PRs will add function in more places, and generalise to deal with other grammar errors.

Changes:

  • Define new util function joinStrings to better combine strings in bot messages.
  • Updated some files (namely colosseum, diary, CAs and music cape reqs) as examples.

Other checks:

  • I have tested all my changes thoroughly.

@gc gc merged commit b70f0a0 into oldschoolgg:master Oct 27, 2024
4 checks passed
@DayV-git DayV-git deleted the tidy_strings branch November 17, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants