fixed LMS simulation command #5985
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Sorry, I don't know how to help with that. If you tag me (@ellipsis-dev) in a comment, I can do one of these things (but not multiple at once):
I am able to see previous issue comments for context. |
|
Code generation is not enabled for @I-am-TURBO in this repository because they haven't been added to the org and/or granted a seat. |
I-am-TURBO
changed the title
|
@ellipsis-dev review and summerize |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 04a4653 in 40 seconds
More details
- Looked at
248lines of code in3files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_CHDKCu7AM3dCUU1J
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
package.json
Outdated
| "node-cron": "^3.0.3", | ||
| "node-fetch": "^2.6.7", | ||
| "nodejs": "^0.0.0", |
There was a problem hiding this comment.
The dependency 'nodejs' is not a valid npm package and should be removed. It seems to be a mistake since 'node' is already included as a dependency.
| "nodejs": "^0.0.0", | |
| @@ -33,6 +35,13 @@ export async function lmsCommand( | |||
| **Total Matches:** ${stats.totalGames}`; | |||
| } | |||
|
|
|||
| if (options.simulate) { | |||
| lmsSimCommand(globalClient.channels.cache.get(channelID.toString()), options.simulate.names); | |||
There was a problem hiding this comment.
The asynchronous function lmsSimCommand should be awaited to ensure all its operations complete before proceeding.
| lmsSimCommand(globalClient.channels.cache.get(channelID.toString()), options.simulate.names); | |
| await lmsSimCommand(globalClient.channels.cache.get(channelID.toString()), options.simulate.names); |
There was a problem hiding this comment.
@gc @themrrobert why is the bot requesting to add this?
removed the 2 added changes
Description:
doing simulation on bso sent minigame trips same as minigame command
Changes:
copied over osb's command
Other checks:
Summary:
Added LMS simulation command and integrated it into the existing LMS command, along with updating dependencies in
package.json.Key points:
lmsSimCommandfunction insrc/lib/minions/functions/lmsSimCommand.tsto simulate LMS minigame.lmsSimCommandintolmsCommandinsrc/mahoji/lib/abstracted_commands/lmsCommand.ts.package.jsonto include new dependenciesnodeandnodejs.Generated with ❤️ by ellipsis.dev