Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BSO wintertodt messages #5905

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Clean up BSO wintertodt messages #5905

merged 1 commit into from
Jul 2, 2024

Conversation

nwjgit
Copy link
Contributor

@nwjgit nwjgit commented Jun 1, 2024

Description:

Clean up BSO wintertodt messages

Changes:

  • put all boosts on the same line after "Boosts:"
  • put all food related messages on the same line after "Food:"
  • remove redundant warm clothing message from showing twice
  • add "2x loot for Firemaking master cape" to the return trip message when the user has their loot doubled by the firemaking master cape.
  • add an await to incrementMinigameScore and return to handleTripFinish to remove two warnings.

Other checks:

before:
Discord_v4ACRIHRo5
after:
Discord_yMfRzqveF9

  • I have tested all my changes thoroughly.

@nwjgit nwjgit added the BSO Bot School Old label Jun 1, 2024
ellipsis-dev[bot]
ellipsis-dev bot reviewed Jun 1, 2024
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 50f848f in 37 seconds

More details
  • Looked at 149 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_arcsoRJvxGLDphxm

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

src/mahoji/lib/abstracted_commands/wintertodtCommand.ts Show resolved Hide resolved
@gc gc merged commit 20b3022 into oldschoolgg:bso Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

Assignees
No one assigned
Labels
BSO Bot School Old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwjgit @gc