Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Logging #76

Open
sinyalee opened this issue Nov 13, 2024 · 0 comments
Open

Fix Logging #76

sinyalee opened this issue Nov 13, 2024 · 0 comments

Comments

@sinyalee
Copy link

sinyalee commented Nov 13, 2024 •
edited
Loading

Issue 1

logging.basicConfig(level=logging.INFO)

This sets global logging level. A library should not change global logging configurations.

Issue 2

logger = logging.getLogger("WebSocketFactory")

Please use logging.getLogger(__name__). Avoid using general name for a specific library.

Issue 3

logger.info("Received message: %s", message)

These are debug messages. It would spam users' log. Please change it to debug level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sinyalee