Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of prompts (reduce subshells, etc.) #281

Open
tomaszkyc opened this issue Jan 2, 2022 · 6 comments
Open

Improve performance of prompts (reduce subshells, etc.) #281

tomaszkyc opened this issue Jan 2, 2022 · 6 comments

Comments

@tomaszkyc
Copy link

Hi everybody!

I'm new one to the oh-my-bash on my mac. I see that installed oh-my-bash + agnoster theme has some input lag for every command that I try (even simple ls -la have some small lag).

Do you have the same issue? Do you know any workaround for that?

@akinomyoga
Copy link
Contributor

There are many possible causes of the delay. Could you describe it in more detail? What exactly do you mean by the input delay? Would you experience the delay between every keystroke? For example, in the case of ls -la, do you experience the delay while inputting the characters ls -la? Or do you experience the delay after you press Enter before the command ls starts? Or do you experience the delay after the result of ls is shown before the next prompt is shown?

@mkieczko96
Copy link

I have probably the same issue. Delay appers after pressing [Enter] key. Eg. while running cd some-dir/ command I get pwd printed and then it takes some time to print a new prompt line.

@akinomyoga
Copy link
Contributor

akinomyoga commented Jan 12, 2022

Thank you for the information. OK, this means that it takes time to generate the prompt contents. I think the delay should become longer in git repositories as reported in #6, #172, and #270, but there is also a delay outside the git repositories because of many forks/execs caused by subshells and external program executions. It would be actually a large rewrite of the entire codebase to minimize the number of forks/execs, so it won't be resolved soon, yet I'll consider it in the future.

@tomaszkyc
Copy link
Author

@akinomyoga sorry for late response but I have the same feelings like @mkieczko96. So I guess that now everything is clear and we can close the issue. Really appreciate your willing to help! 👍

@akinomyoga
Copy link
Contributor

akinomyoga commented Jan 13, 2022

Thank you! But I'd like to consider it in the future anyway, so let us keep this open.

@akinomyoga akinomyoga reopened this Jan 13, 2022
@akinomyoga akinomyoga changed the title Commands has some input delay Improve performance of prompts (reduce subshells, etc.) Jan 13, 2022
@conn-dev
Copy link

anyone patch for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants