Fix: Contact link does not work properly in the footer #38
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for landing-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shivankacker
approved these changes
Dec 11, 2024
shivankacker
requested changes
Dec 11, 2024
There was a problem hiding this comment.
@AdityaJ2305 this should bring you to the home page, not the footer.
Ok, so we should remove the contact from header when we are already on home page ? I thought on footer we got GitHub yt slack links to get assistance and as per issue mentioned the bug was with scrolling |
|
@AdityaJ2305 the links stay the same. It will take you to the contact section of the home page. It is fine if it does not scroll for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Reviewer
@shivankacker
Screen-Recording
Screen.Recording.2024-12-10.at.11.10.27.PM.mp4