Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed lodash imports and dependencies and wrote js equivalents #9116
base: develop
Are you sure you want to change the base?
removed lodash imports and dependencies and wrote js equivalents #9116
Changes from 8 commits
7f75a18
cc88800
f13a324
17931f8
de43d86
1a136f4
87dbee1
e2abfa6
ed43c9c
a8950c3
0d2e876
7bd57e5
e0b6526
b3feb64
95d2bd8
25ea91b
14e3239
9fff886
b029aca
30a9311
e478511
4552e02
13cf031
07463bc
bf56a6a
55a0c4a
8647be9
598aae4
eac2760
449d574
2c521a1
1790cd6
00e3ced
d3a4d98
8351876
f0ae6b2
b58bd88
e6ec037
07ae5a2
9a89ca2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace all usages of setNestedValueSafely with proper type-safe change handlers. And not have this helper function altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SwanandBhuskute This seems like a usage of setNestedValueSafely
Check warning
Code scanning / CodeQL
Prototype-polluting function Medium