Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Update Allows Negative Quantity and Empty Description Fields #9053

Open
JavidSumra opened this issue Nov 8, 2024 · 9 comments · May be fixed by #9062
Open

Resource Update Allows Negative Quantity and Empty Description Fields #9053

JavidSumra opened this issue Nov 8, 2024 · 9 comments · May be fixed by #9062
Assignees

Comments

@JavidSumra
Copy link
Contributor

Bug Description
The quantity field allows negative values during resource updates, and the mandatory description field can be left empty, which should not be allowed.


Steps to Reproduce

  1. Navigate to resource/list.
  2. Select All Details of any resource.
  3. Click on Update Status/Details.
  4. Enter a negative value in the Required Quantity field and clear the Description field.
  5. Attempt to update the resource and observe the behavior.

Expected Behavior

  • The Required Quantity field should not accept negative values.
  • The Description field should be mandatory, preventing updates if left empty.

Screenshots
Screenshot showing error


Environment

  • OS: Windows
  • Browser: Chrome
  • Version: 130.0.6723.117
@JavidSumra
Copy link
Contributor Author

Hey Team Can You please Assign this issue to me

@Jacobjeevan Jacobjeevan added this to Care Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Nov 8, 2024
@Jacobjeevan Jacobjeevan moved this from Triage to Up Next in Care Nov 8, 2024
@JavidSumra
Copy link
Contributor Author

Hey @Jacobjeevan Shall I update Resource Request Form as well with min val 0?

@Jacobjeevan
Copy link
Contributor

Yea, can't think of a reason why we shouldn't have the minimum value as 1 instead 🤔

@JavidSumra
Copy link
Contributor Author

So Shall I go with min value of 1?

@Jacobjeevan
Copy link
Contributor

yea

@kihan2518B
Copy link

kihan2518B commented Nov 8, 2024

this issue is solved in PR #8956
Image

@JavidSumra
Copy link
Contributor Author

Maybe but I'm updating other components as well.

@JavidSumra JavidSumra linked a pull request Nov 8, 2024 that will close this issue
6 tasks
@JavidSumra
Copy link
Contributor Author

Hey @Jacobjeevan as per the existing Code I think there are 4 Required Fields,

  1. Name of resource approving facility,
  2. What facility would you like to assign the request to,
  3. Request Title,
  4. Description of request
    So shall I update the Related Test suit as per requirements?

@Jacobjeevan
Copy link
Contributor

Hey @Jacobjeevan as per the existing Code I think there are 4 Required Fields,

1. Name of resource approving facility,

2. What facility would you like to assign the request to,

3. Request Title,

4. Description of request
   So shall I update the Related Test suit as per requirements?

Yea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Up Next
Development

Successfully merging a pull request may close this issue.

3 participants