Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Adds support for filtering by event types #7877

Open
rithviknishad opened this issue May 22, 2024 · 11 comments
Open

Events: Adds support for filtering by event types #7877

rithviknishad opened this issue May 22, 2024 · 11 comments
Assignees

Comments

@rithviknishad
Copy link
Member

rithviknishad commented May 22, 2024

Is your feature request related to a problem? Please describe.
Currently it is not possible to filter events by event types.

Describe the solution you'd like
Add a multi select filter in the events list to filter by one or more event types.

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1

image
@Atharva-Kanherkar
Copy link

Hi @rithviknishad Can you provide me a high level view on how to get started on this? Also, I wanna work on it, may i?

@rithviknishad
Copy link
Member Author

Hey @Atharva-Kanherkar

Yes you can work on this!

Solution 1

To get the list of available event types, you'll need to fetch the event types from the API:
https://careapi.ohc.network/swagger/#/event_types

And then when fetching consultation events, pass the event type id to the filter.
https://careapi.ohc.network/swagger/#/events/api_v1_consultation_events_list

You might want to update the backend to support filtering by multiple event type ID's.

Solution 2 (preferred)

Same as solution 1, except that instead of fetching the event types from API, change the consultation events filter to filter by event names instead.

cc: @sainak

@rithviknishad
Copy link
Member Author

The UI could be kept similar to the filter popover present in the daily rounds filter. Feel free to suggest better alternatives if you have any in mind!

image

@Atharva-Kanherkar
Copy link

The UI could be kept similar to the filter popover present in the daily rounds filter. Feel free to suggest better alternatives if you have any in mind!

image

Sure! Just give me some time to get to understand the codebase better. I am very interested to contribute to the next js frontend. Please bear with me as I progress. Thank you so much .

@rithviknishad
Copy link
Member Author

Sure! Feel free to drop a comment if you are facing any difficulty understanding something.

@Sulochan-khadka
Copy link
Contributor

@Atharva-Kanherkar Well , if you get stuck at something , do share . Will help if I can...

Copy link

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Jun 27, 2024
@rithviknishad
Copy link
Member Author

@Atharva-Kanherkar unassigning due to no activity.

@Atharva-Kanherkar
Copy link

Atharva-Kanherkar commented Aug 12, 2024 via email

@sainak sainak added this to Care Sep 7, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Sep 7, 2024
@sainak sainak moved this from Triage to Up Next in Care Sep 7, 2024
@sainak sainak moved this from Up Next to In Progress in Care Oct 21, 2024
@bodhish
Copy link
Member

bodhish commented Nov 25, 2024

@sainak doesn this have a linked PR?

@sainak
Copy link
Member

sainak commented Nov 25, 2024

@bodhish this was blocked by ohcnetwork/care#2598

@sainak sainak moved this from In Progress to Blocked in Care Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

5 participants