Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required validation for Max dosage. #2384

Closed
wants to merge 3 commits into from

Conversation

akat5uki
Copy link

@akat5uki akat5uki commented Aug 21, 2024

Proposed Changes

  • Added validation to check if max dosage is less than base dosage. If that is the case, then raise validation error.

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@akat5uki akat5uki requested a review from a team as a code owner August 21, 2024 22:32
@akat5uki akat5uki marked this pull request as draft August 21, 2024 22:58
@akat5uki akat5uki marked this pull request as ready for review August 21, 2024 22:59
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test cases

care/facility/api/serializers/prescription.py Outdated Show resolved Hide resolved
@akat5uki akat5uki requested a review from sainak August 22, 2024 12:13
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainak
Copy link
Member

sainak commented Aug 23, 2024

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validations lgtm; needs test cases and lint issue fixes as mentioned

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (a4e2f8b) to head (4f7b0d8).
Report is 49 commits behind head on develop.

Files with missing lines Patch % Lines
care/facility/api/serializers/prescription.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2384      +/-   ##
===========================================
- Coverage    63.86%   63.85%   -0.01%     
===========================================
  Files          239      239              
  Lines        13439    13441       +2     
  Branches      1914     1915       +1     
===========================================
  Hits          8583     8583              
- Misses        4508     4509       +1     
- Partials       348      349       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari
Copy link
Member

Closing because of inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for max dosage in PRN prescription
4 participants