-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added required validation for Max dosage. #2384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akat5uki lint checks are failing, run precommit
and add test cases for your change in https://github.com/coronasafe/care/blob/a4e2f8be3935060811e51141c237437298825a72/care/facility/tests/test_medicine_api.py#L9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validations lgtm; needs test cases and lint issue fixes as mentioned
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2384 +/- ##
===========================================
- Coverage 63.86% 63.85% -0.01%
===========================================
Files 239 239
Lines 13439 13441 +2
Branches 1914 1915 +1
===========================================
Hits 8583 8583
- Misses 4508 4509 +1
- Partials 348 349 +1 ☔ View full report in Codecov by Sentry. |
Closing because of inactivity |
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins