Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for max dosage in PRN prescription #2383

Open
sainak opened this issue Aug 21, 2024 · 14 comments · May be fixed by #2531
Open

Add validation for max dosage in PRN prescription #2383

sainak opened this issue Aug 21, 2024 · 14 comments · May be fixed by #2531
Assignees
Labels

Comments

@sainak
Copy link
Member

sainak commented Aug 21, 2024

image

Add backend validation to check that max dosage in 24 is greater than or equal to base dosage

https://github.com/coronasafe/care/blob/68a3a8281cf72eb859b5951ffbadda0399c3010f/care/facility/api/serializers/prescription.py#L97-L151

@hollermay
Copy link

I would like to work on this issue.

@himanshu-sharmav
Copy link

Hi @sainak I would like to work on this issue.

@himanshu-sharmav
Copy link

Update I am working on it.

@himanshu-sharmav
Copy link

@sainak Can I add validation to the Prescription model itself?

@himanshu-sharmav
Copy link

@sainak need some help regarding api call?
I have added some validation in the prescription serializer and want to test it
How to do so?

@himanshu-sharmav
Copy link

@sainak @rithviknishad Please review is this the required output, should I start writing the tests and please guide me to do so.
Image

@rithviknishad
Copy link
Member

Yup, lgtm

@himanshu-sharmav
Copy link

@rithviknishad Please guide me how to write the tests and what exactly is required for the pr to get merged

@himanshu-sharmav
Copy link

@rithviknishad @sainak Please review my PR for the issue.

@DraKen0009
Copy link
Contributor

Can I pick this up ? There haven't been any response since last 2 weeks

@himanshu-sharmav
Copy link

himanshu-sharmav commented Nov 2, 2024

I was busy with my exams and have already raised the pr just some issues with that will try to resolve.

@Harsh-D-2004
Copy link

Hey can i pick this issue up?
@sainak

@himanshu-sharmav
Copy link

I have already raised the pr just some adjustments need to be done.

@Harsh-D-2004
Copy link

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment