-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc support #1
Comments
Thanks for the feedback! 👋
|
Hi, answering for @steeve since he's a bit busy. We're talking about protoc plugins for a specific language. This plugin is what zig-protobuf implements in https://github.com/Arwalk/zig-protobuf/blob/master/bootstrapped-generator/main.zig#L102-L110 We could contribute a similar plugin that take a FileDescriptorProto and output a .zig file similar to what gremlin generates already. I've already forked https://github.com/gwenzek/zig-protobuf to make it generate one .zig file for each .proto, and use modules for imports instead of using relative imports, as well as simplifying a bit the generated code. Personally I prefer the API generated by gremlin, so that's why we consider switching to it, and we can contribute the missing piece. But if you feel this is beyond your original goals, we can also do this in a separate repository. |
@gwenzek Thanks for the details. Yes, I think adding optional protoc support would be a valuable addition |
Hi,
First of all, congratulations, this looks great!
Would you be open to
protoc
support? It's mostly https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/descriptor.proto on stdin and file contents on stdout.This would ease support for other build systems, most notably regarding well known types.
Cheers,
The text was updated successfully, but these errors were encountered: