-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue#8 added Day Type from time library #21
base: master
Are you sure you want to change the base?
Conversation
Thank you! Looks good. As you might have noticed there are two overlapping pieces of API: the 'getX' functions and the Traversal s. I like traversals better as they are more flexible but this is a longer-term design question, to be explored with concrete examples. |
I've added some additional types now. |
Sorry, I've noticed that the checks in the CI failed, but I don't know why that is. It builds and tests pass locally on my machine. |
@AR2202 the CI error is due to the version bound on the Error: While constructing the build plan, the following exceptions were encountered: In the dependencies for heidi-0.3.1:
needed since heidi is a build target. Some different approaches to resolving this:
|
Thanks @ocramz for your explanation. |
I added the 'Day' type from the time library, which represents a Date. This is a first attempt and if this is OK, I can add more types from the time library.