Initial work to implement Sapphire snap connection #431
+86
−25,911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
CedarMist
force-pushed
the
CedarMist/sapphire-snap
branch
from
47c82fc to
9d74f0f
Compare
buberdds
reviewed
Dec 10, 2024
| @@ -43,6 +44,7 @@ export function isLegacyProvider<T extends object>( | |||
|
|
|||
| export interface SapphireWrapOptions { | |||
| fetcher: KeyFetcher; | |||
There was a problem hiding this comment.
Options object is optional. When provided, TS requires fetcher, but we should be able just to set enableSapphireSnap flag. As fetcher always defaults to new KeyFetcher() should it now be fetcher: KeyFetcher | undefined; ?
| @@ -80,10 +82,10 @@ export function isWrappedEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
| * @param options (optional) Re-use parameters from other providers | |||
| * @returns Sapphire wrapped provider | |||
| */ | |||
| export function wrapEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
| export async function wrapEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
There was a problem hiding this comment.
Does it affect all integrations? For example I don't see ether-v6 is relying on wrapEthereumProvider. It has it's own logic. Do we plan to apply the same code in a few places, or share some snap utils across packages?
I guess for ether-v6 we should call notifySapphireSnap right after https://github.com/oasisprotocol/sapphire-paratime/blob/main/integrations/ethers-v6/src/index.ts#L96
buberdds
reviewed
Dec 10, 2024
| params: { | ||
| id: transactionData, | ||
| ephemeralSecretKey: hexlify(secretKey), | ||
| peerPublicKey: peerPublicKey.key, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #389
This provides the decryption keys to snap.
Warning
If an RPC server pretends to implement the MetaMask snap protocol it could trick users into revealing the transaction encryption key.
For this reason, we have to explicitly enable Snap support in the dApp, by passing the
enableSapphireSnapoption.Usage:
This must only be done if the dApp is sure that the provider it's connecting to is MetaMask.
TODO:
wallet_invokeSnap