Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Sapphire deployment pattern section #818

Merged
merged 1 commit into from
Jun 4, 2024
Merged

docs: Add Sapphire deployment pattern section #818

merged 1 commit into from
Jun 4, 2024

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented May 13, 2024

Description

Add necessary file reference. Blocked by oasisprotocol/sapphire-paratime#313.

@aefhm aefhm self-assigned this May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit a58b7b2
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/665e84fde6e5b20008b52080
😎 Deploy Preview https://deploy-preview-818--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aefhm aefhm added documentation Improvements or additions to documentation p:1 Medium priority labels May 13, 2024
@matevz
Copy link
Member

matevz commented May 23, 2024

You can also bump the external/sapphire-paratime repo in this PR so that the new proxy.md will actually be there and tests will pass.

@aefhm
Copy link
Contributor Author

aefhm commented May 28, 2024

You can also bump the external/sapphire-paratime repo in this PR so that the new proxy.md will actually be there and tests will pass.

That is after merging the other PR right? Submodule config looks set to main.

Edit. I think I figured it out.

@aefhm aefhm force-pushed the aefhm-patch-2 branch 3 times, most recently from f8f3015 to d50effa Compare May 29, 2024 20:27
@aefhm aefhm requested a review from matevz May 29, 2024 20:27
@aefhm aefhm changed the title Add Sapphire proxy section Add Sapphire deployment pattern section May 29, 2024
@aefhm aefhm marked this pull request as draft May 29, 2024 20:30
@aefhm aefhm changed the title Add Sapphire deployment pattern section docs: Add Sapphire deployment pattern section May 29, 2024
@aefhm aefhm force-pushed the aefhm-patch-2 branch 4 times, most recently from c9061f1 to 160fad3 Compare May 29, 2024 22:18
@aefhm aefhm marked this pull request as ready for review May 29, 2024 22:18
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks correct ;)

@aefhm aefhm enabled auto-merge June 4, 2024 03:07
@aefhm aefhm merged commit f9631cb into main Jun 4, 2024
6 of 7 checks passed
@aefhm aefhm deleted the aefhm-patch-2 branch June 4, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p:1 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants