Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _mainnet, _testnet -> -mainnet, -testnet in all examples #458

Closed
matevz opened this issue Jun 22, 2023 · 1 comment
Closed

Replace _mainnet, _testnet -> -mainnet, -testnet in all examples #458

matevz opened this issue Jun 22, 2023 · 1 comment
Labels
examples Fixes in the examples code

Comments

@matevz
Copy link
Member

matevz commented Jun 22, 2023 •
edited
Loading

Ethereum's chain list standard prefers dashes instead of underscores for naming the networks. We're currently using underscores, because dashes are interpreted as minus in javascript and you would need to put the network name inside quotes then. However, this seems to become standard in the Ethereum world, so make it consistent.

Replace:

  • emerald_mainnet -> emerald
  • emerald_testnet -> emerald-testnet
  • emerald_localnet -> emerald-localnet
  • sapphire_mainnet -> sapphire
  • sapphire_testnet -> sapphire-testnet
  • sapphire_localnet -> sapphire-localnet

Replace the network names in the truffle/hardhat configurations in the docs, sapphire-paratime, playground and all demo- repos.
@matevz matevz added the examples Fixes in the examples code label Jun 22, 2023
@matevz
Copy link
Member Author

matevz commented Dec 11, 2023

Fixed in #636

@matevz matevz closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
examples Fixes in the examples code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matevz