Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Mermaid diagram SVGs in dark mode #1070

Open
aefhm opened this issue Dec 20, 2024 · 0 comments
Open

docs: Improve Mermaid diagram SVGs in dark mode #1070

aefhm opened this issue Dec 20, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@aefhm
Copy link
Contributor

aefhm commented Dec 20, 2024

Description

Relates to #308.

Mermaid diagrams currently are exported to an SVG that is read inline which keeps a white background even in dark mode.

We would like to reduce the contrast and improve the UX for devs using dark mode. Mermaid does not currently support dark mode detecting SVGs through CSS, but does pass themes into exported SVG and also supports overrides.

Themed images is another approach. I encountered some difficulties during the last attempt as inlined SVGs lost some attributes, but we can give it another try. Other approaches are welcome too.

@aefhm aefhm added the documentation Improvements or additions to documentation label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant