Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove why page and redirect to OPF #1052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Dec 11, 2024

Description

Close #1038

TODO

  • Check URL redirect

@aefhm aefhm self-assigned this Dec 11, 2024
@aefhm aefhm added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers p:1 Medium priority labels Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit 6ecb47e
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/675a6f4675fcbc00085f7178
😎 Deploy Preview https://deploy-preview-1052--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aefhm aefhm force-pushed the xz/1038-remove-why-page branch 2 times, most recently from 01ca06e to e95948e Compare December 11, 2024 23:29
@aefhm aefhm force-pushed the xz/1038-remove-why-page branch from e95948e to 6ecb47e Compare December 12, 2024 05:06
@aefhm aefhm marked this pull request as ready for review December 12, 2024 05:19
@aefhm aefhm requested a review from matevz December 12, 2024 05:20
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions. Otherwise looks good.

@@ -183,13 +183,17 @@ export const redirectsOptions: Options = {
'/oasis-core-ledger/release-process', // #626 Deprecate oasis-core-ledger
]
},
{
to: 'https://oasisprotocol.org/',
from: '/general/oasis-network/why-oasis', // #1052 Redirect why page to OPF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from: '/general/oasis-network/why-oasis', // #1052 Redirect why page to OPF
from: [
'/general/oasis-network/why-oasis', // #1052 Redirect why page to OPF
'/oasis-network-primer/', // #200 Restructure docs
]

@@ -49,5 +49,5 @@ The versatility of the ParaTime layer allows the Oasis Network to expand and gro
### Learn more

<DocCard item={
findSidebarItem('/general/oasis-network/why-oasis')
findSidebarItem('/general/oasis-network/token-metrics-and-distribution')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely remove the "Learn more" section here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers p:1 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Remove why oasis page
2 participants