We should error if the contract deploy header is provided with undefined or invalid values

[armaniferrante]

The following should error on the client side:

contract.deploy({
          data: bytecode,
          header: {
            confidential: undefined,
            expiry: undefined
        }
}).send();

[eauge]

@armaniferrante why should this error? I assume this should be the same as

contract.deploy({
          data: bytecode,
          header: {}
}).send();

Should this also error?

[armaniferrante]

I don't think that should error. However, confidential: 12354 or expiry: "have a nice day" should probably error.

[eauge]

@armaniferrante yes those error. As an example https://github.com/oasislabs/e2e-tests/blob/master/test/11_test_failures.js#L84