Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax jsonschema dependency #224

Closed
ostefano opened this issue Dec 27, 2023 · 5 comments
Closed

Relax jsonschema dependency #224

ostefano opened this issue Dec 27, 2023 · 5 comments
Assignees

Comments

@ostefano
Copy link
Contributor

ostefano commented Dec 27, 2023

Any hard reason why the jsonschema dependency is so restrictive: jsonschema[format-nongpl]>=4.6.0,<4.18.0?

As things stand it is not possible to install cti-stix-validator together with pymisp, with cti-stix-validator having the most restrictive selection.

@ejratl
Copy link
Contributor

ejratl commented Jan 2, 2024

As I recall, there was a breaking change in jsonschema that requires updates to the validator code to work with 4.18.0 and later. Since we don't yet have a pull request for the new way of doing things, upgrading to the latest version of jsonschema is not possible.
The release notes for jsonschema 4.18.0 describe the change that is needed: https://github.com/python-jsonschema/jsonschema/releases/tag/v4.18.0
"jsonschema.RefResolver is now deprecated in favor of the new referencing library."

@ejratl
Copy link
Contributor

ejratl commented Jan 2, 2024

This issue is a duplicate of #216

@ostefano
Copy link
Contributor Author

Here the PR fixing this issue: #228

@ostefano
Copy link
Contributor Author

@clenk @rpiazza could you review the linked PR? Thanks!

@ostefano
Copy link
Contributor Author

ostefano commented Apr 3, 2024

This has been fixed #228

@ostefano ostefano closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants