Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-1.2] Port #10583 #10755 #11298 #505

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

weiting-chen
Copy link
Collaborator

@weiting-chen weiting-chen commented Nov 23, 2024

Bikramjeet Vig and others added 3 commits November 23, 2024 06:56
…ncubator#10583)

Summary:
Pull Request resolved: facebookincubator#10583

This fixes min/max aggregates to handle NaN values correctly when they are pushed down to the scan operator. Specifically, the change ensures that NaN values are considered greater than infinity.

Reviewed By: zacw7

Differential Revision: D60297934

fbshipit-source-id: 3398ba24d6fc70bbd0d8583d2949391b0824099c
)

Summary:
X-link: facebookincubator/nimble#72

Pull Request resolved: facebookincubator#10755

Currently reader value hook is not considering schema evolution at all, this change fix that.

Reviewed By: kevinwilfong

Differential Revision: D61229494

fbshipit-source-id: 729bb90611fb3164282b524376eda20985a30194
Summary:
Currently, `int64_t` enables push-down for decimal type. This PR disables aggregate pushdown for decimal type regardless of c++ type.

Fixes facebookincubator#11290

Pull Request resolved: facebookincubator#11298

Reviewed By: Yuhta

Differential Revision: D65834210

Pulled By: kevinwilfong

fbshipit-source-id: 422f7eda8f4184c6fa83055e7cf430ff5053d387
@weiting-chen
Copy link
Collaborator Author

Run Pass Velox UT testing in Jenkins.

@weiting-chen weiting-chen changed the title [Branch-1.2] Port #10583 #10755 [Branch-1.2] Port #10583 #10755 #11298 Nov 23, 2024
@weiting-chen weiting-chen merged commit 74857c2 into oap-project:branch-1.2 Nov 23, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants