puppet agent -t fails due to missing /usr/bin/add-apt-repository

[stuartf]

Newly provisioned machines don't appear to have /usr/bin/add-apt-repository so puppet gives an error like:
Error: /Stage[main]/Oaeservice::Deps::Ppa::Oae/Apt::Ppa[ppa:oae/deps]/Exec[add-apt-repository-ppa:oae/deps]/returns: change from notrun to 0 failed: Could not find command '/usr/bin/add-apt-repository'

/usr/bin/add-apt-repository comes from the python-software-properties package, so that should be installed before trying to run add-apt-repository

[mrvisser]

This was probably just an error waiting to happen, as before it probably just so happened that python-software-properties was installed before the add-apt-repository was performed.

Currently we have this here:

root@puppet:/etc/puppet/puppet-hilary# git grep python-software-properties
modules/oaeservice/manifests/deps/common.pp:    Class['::apt::update'] -> Package <| title != "python-software-properties" and title != "software-properties-common" |>

We'll have to add some similar constraints that tell puppet to run the python-software-properties package before any call to maybe ::apt::source. Which could look something like this (probably syntax errors):

Package['python-software-properties'] -> Class['::apt::update']
Package['python-software-properties'] -> Apt::Update <| |>