Fix deprecated warnings

[simong]

We should clean up our templates/logic a bit so we have less deprecation warnings.

• Stop using templatedir
• Stop using import
• Use proper variable access getters in templates (this one has the most warnings and is the easiest to fix)

Full log:

==> default: Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
==> default:    (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1095:in `issue_deprecations')
==> default: Warning: The use of 'import' is deprecated at /vagrant/site.pp:17. See http://links.puppetlabs.com/puppet-import-deprecation
==> default:    (at grammar.ra:610:in `_reduce_190')
==> default: Warning: Variable access via 'cluster_name' is deprecated. Use '@cluster_name' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:10
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:10:in `result')
==> default: Warning: Variable access via 'initial_token' is deprecated. Use '@initial_token' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:37
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:37:in `result')
==> default: Warning: Variable access via 'cassandra_data_dir' is deprecated. Use '@cassandra_data_dir' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:113
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:113:in `result')
==> default: Warning: Variable access via 'cassandra_data_dir' is deprecated. Use '@cassandra_data_dir' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:196
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:196:in `result')
==> default: Warning: Variable access via 'hosts' is deprecated. Use '@hosts' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:239
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:239:in `result')
==> default: Warning: Variable access via 'listen_address' is deprecated. Use '@listen_address' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:331
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:331:in `result')
==> default: Warning: Variable access via 'listen_address' is deprecated. Use '@listen_address' instead. template[/vagrant/modules/cassandra/templates/cassandra.yaml.erb]:332
==> default:    (at /vagrant/modules/cassandra/templates/cassandra.yaml.erb:332:in `result')
==> default: Warning: Variable access via 'cassandra_home' is deprecated. Use '@cassandra_home' instead. template[/vagrant/modules/cassandra/templates/cassandra-env.sh.erb]:17
==> default:    (at /vagrant/modules/cassandra/templates/cassandra-env.sh.erb:17:in `result')
==> default: Warning: Variable access via 'rsyslog_enabled' is deprecated. Use '@rsyslog_enabled' instead. template[/vagrant/modules/cassandra/templates/log4j-server.properties.erb]:18
==> default:    (at /vagrant/modules/cassandra/templates/log4j-server.properties.erb:18:in `result')
==> default: Warning: Variable access via 'rsyslog_enabled' is deprecated. Use '@rsyslog_enabled' instead. template[/vagrant/modules/cassandra/templates/log4j-server.properties.erb]:29
==> default:    (at /vagrant/modules/cassandra/templates/log4j-server.properties.erb:29:in `result')
==> default: Warning: Variable access via 'heap_size_mb' is deprecated. Use '@heap_size_mb' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.erb]:63
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.erb:63:in `result')
==> default: Warning: Variable access via 'heap_newsize_mb' is deprecated. Use '@heap_newsize_mb' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.erb]:66
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.erb:66:in `result')
==> default: Warning: Variable access via 'path_data' is deprecated. Use '@path_data' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.erb]:88
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.erb:88:in `result')
==> default: Warning: Variable access via 'path_data' is deprecated. Use '@path_data' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb]:157
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb:157:in `result')
==> default: Warning: Variable access via 'host_address' is deprecated. Use '@host_address' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb]:214
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb:214:in `result')
==> default: Warning: Variable access via 'host_port' is deprecated. Use '@host_port' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb]:226
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb:226:in `result')
==> default: Warning: Variable access via 'search_hosts' is deprecated. Use '@search_hosts' instead. template[/vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb]:331
==> default:    (at /vagrant/modules/elasticsearch/templates/elasticsearch.yml.erb:331:in `result')
==> default: Warning: Variable access via 'rsyslog_enabled' is deprecated. Use '@rsyslog_enabled' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:2
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:2:in `result')
==> default: Warning: Variable access via 'rsyslog_enabled' is deprecated. Use '@rsyslog_enabled' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:24
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:24:in `result')
==> default: Warning: Variable access via 'rsyslog_host' is deprecated. Use '@rsyslog_host' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:81
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:81:in `result')
==> default: Warning: Variable access via 'rsyslog_host' is deprecated. Use '@rsyslog_host' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:90
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:90:in `result')
==> default: Warning: Variable access via 'rsyslog_host' is deprecated. Use '@rsyslog_host' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:99
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:99:in `result')
==> default: Warning: Variable access via 'rsyslog_host' is deprecated. Use '@rsyslog_host' instead. template[/vagrant/modules/elasticsearch/templates/logging.yml.erb]:108
==> default:    (at /vagrant/modules/elasticsearch/templates/logging.yml.erb:108:in `result')
==> default: Warning: Variable access via 'oae_db_hosts' is deprecated. Use '@oae_db_hosts' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:32
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:32:in `result')
==> default: Warning: Variable access via 'oae_db_keyspace' is deprecated. Use '@oae_db_keyspace' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:33
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:33:in `result')
==> default: Warning: Variable access via 'oae_db_replication' is deprecated. Use '@oae_db_replication' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:38
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:38:in `result')
==> default: Warning: Variable access via 'oae_db_strategy_class' is deprecated. Use '@oae_db_strategy_class' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:39
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:39:in `result')
==> default: Warning: Variable access via 'enable_abiword' is deprecated. Use '@enable_abiword' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:61
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:61:in `result')
==> default: Warning: Variable access via 'session_key' is deprecated. Use '@session_key' instead. template[/vagrant/modules/etherpad/templates/etherpad.settings.json.erb]:115
==> default:    (at /vagrant/modules/etherpad/templates/etherpad.settings.json.erb:115:in `result')
==> default: Warning: Variable access via 'etherpad_dir' is deprecated. Use '@etherpad_dir' instead. template[/vagrant/modules/etherpad/templates/upstart_etherpad.conf.erb]:6
==> default:    (at /vagrant/modules/etherpad/templates/upstart_etherpad.conf.erb:6:in `result')
==> default: Warning: Variable access via 'etherpad_user' is deprecated. Use '@etherpad_user' instead. template[/vagrant/modules/etherpad/templates/upstart_etherpad.conf.erb]:8
==> default:    (at /vagrant/modules/etherpad/templates/upstart_etherpad.conf.erb:8:in `result')
==> default: Warning: Variable access via 'config_log_syslog_ip' is deprecated. Use '@config_log_syslog_ip' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:17
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:17:in `result')
==> default: Warning: Variable access via 'config_ui_path' is deprecated. Use '@config_ui_path' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:34
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:34:in `result')
==> default: Warning: Variable access via 'config_cassandra_hosts' is deprecated. Use '@config_cassandra_hosts' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:39
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:39:in `result')
==> default: Warning: Variable access via 'config_cassandra_keyspace' is deprecated. Use '@config_cassandra_keyspace' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:40
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:40:in `result')
==> default: Warning: Variable access via 'config_cassandra_timeout' is deprecated. Use '@config_cassandra_timeout' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:43
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:43:in `result')
==> default: Warning: Variable access via 'config_cassandra_replication' is deprecated. Use '@config_cassandra_replication' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:44
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:44:in `result')
==> default: Warning: Variable access via 'config_cassandra_strategy_class' is deprecated. Use '@config_cassandra_strategy_class' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:45
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:45:in `result')
==> default: Warning: Variable access via 'config_redis_host' is deprecated. Use '@config_redis_host' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:57
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:57:in `result')
==> default: Warning: Variable access via 'config_redis_port' is deprecated. Use '@config_redis_port' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:58
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:58:in `result')
==> default: Warning: Variable access via 'config_servers_admin_host' is deprecated. Use '@config_servers_admin_host' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:76
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:76:in `result')
==> default: Warning: Variable access via 'config_servers_server_internal_address' is deprecated. Use '@config_servers_server_internal_address' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:78
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:78:in `result')
==> default: Warning: Variable access via 'config_servers_use_https' is deprecated. Use '@config_servers_use_https' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:80
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:80:in `result')
==> default: Warning: Variable access via 'config_servers_strict_https' is deprecated. Use '@config_servers_strict_https' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:81
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:81:in `result')
==> default: Warning: Variable access via 'upload_files_dir' is deprecated. Use '@upload_files_dir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:98
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:98:in `result')
==> default: Warning: Variable access via 'config_files_tmp_dir' is deprecated. Use '@config_files_tmp_dir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:99
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:99:in `result')
==> default: Warning: Variable access via 'config_files_tmp_upload_dir' is deprecated. Use '@config_files_tmp_upload_dir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:100
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:100:in `result')
==> default: Warning: Variable access via 'config_cookie_secret' is deprecated. Use '@config_cookie_secret' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:112
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:112:in `result')
==> default: Warning: Variable access via 'config_log_syslog_ip' is deprecated. Use '@config_log_syslog_ip' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:117
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:117:in `result')
==> default: Warning: Variable access via 'config_telemetry_circonus_url' is deprecated. Use '@config_telemetry_circonus_url' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:147
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:147:in `result')
==> default: Warning: Variable access via 'config_search_hosts' is deprecated. Use '@config_search_hosts' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:189
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:189:in `result')
==> default: Warning: Variable access via 'config_search_enabled' is deprecated. Use '@config_search_enabled' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:227
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:227:in `result')
==> default: Warning: Variable access via 'config_mq_hosts' is deprecated. Use '@config_mq_hosts' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:242
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:242:in `result')
==> default: Warning: Variable access via 'config_previews_enabled' is deprecated. Use '@config_previews_enabled' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:273
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:273:in `result')
==> default: Warning: Variable access via 'config_previews_tmp_dir' is deprecated. Use '@config_previews_tmp_dir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:275
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:275:in `result')
==> default: Warning: Variable access via 'config_previews_tmp_dir' is deprecated. Use '@config_previews_tmp_dir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:276
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:276:in `result')
==> default: Warning: Variable access via 'config_previews_credentials_username' is deprecated. Use '@config_previews_credentials_username' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:295
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:295:in `result')
==> default: Warning: Variable access via 'config_previews_credentials_password' is deprecated. Use '@config_previews_credentials_password' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:296
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:296:in `result')
==> default: Warning: Variable access via 'config_signing_key' is deprecated. Use '@config_signing_key' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:308
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:308:in `result')
==> default: Warning: Variable access via 'config_activity_enabled' is deprecated. Use '@config_activity_enabled' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:333
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:333:in `result')
==> default: Warning: Variable access via 'config_activity_redis_host' is deprecated. Use '@config_activity_redis_host' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:353
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:353:in `result')
==> default: Warning: Variable access via 'config_email_debug' is deprecated. Use '@config_email_debug' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:382
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:382:in `result')
==> default: Warning: Variable access via 'config_email_customEmailTemplatesDir' is deprecated. Use '@config_email_customEmailTemplatesDir' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:383
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:383:in `result')
==> default: Warning: Variable access via 'config_email_deduplicationInterval' is deprecated. Use '@config_email_deduplicationInterval' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:384
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:384:in `result')
==> default: Warning: Variable access via 'config_email_throttleCount' is deprecated. Use '@config_email_throttleCount' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:386
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:386:in `result')
==> default: Warning: Variable access via 'config_email_throttleTimespan' is deprecated. Use '@config_email_throttleTimespan' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:387
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:387:in `result')
==> default: Warning: Variable access via 'config_email_transport' is deprecated. Use '@config_email_transport' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:389
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:389:in `result')
==> default: Warning: Variable access via 'config_email_sendmail_path' is deprecated. Use '@config_email_sendmail_path' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:391
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:391:in `result')
==> default: Warning: Variable access via 'config_etherpad_api_key' is deprecated. Use '@config_etherpad_api_key' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:423
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:423:in `result')
==> default: Warning: Variable access via 'config_etherpad_internal_hosts' is deprecated. Use '@config_etherpad_internal_hosts' instead. template[/vagrant/modules/hilary/templates/config.js.erb]:425
==> default:    (at /vagrant/modules/hilary/templates/config.js.erb:425:in `result')
==> default: Warning: Variable access via 'app_root_dir' is deprecated. Use '@app_root_dir' instead. template[/vagrant/modules/hilary/templates/upstart_hilary.conf.erb]:22
==> default:    (at /vagrant/modules/hilary/templates/upstart_hilary.conf.erb:22:in `result')
==> default: Warning: Variable access via 'module_name' is deprecated. Use '@module_name' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq.config]:2
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq.config:2:in `result')
==> default: Warning: Variable access via 'config_cluster' is deprecated. Use '@config_cluster' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq.config]:4
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq.config:4:in `result')
==> default: Warning: Variable access via 'cluster_disk_nodes' is deprecated. Use '@cluster_disk_nodes' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq.config]:5
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq.config:5:in `result')
==> default: Warning: Variable access via 'config_stomp' is deprecated. Use '@config_stomp' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq.config]:7
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq.config:7:in `result')
==> default: Warning: Variable access via 'port' is deprecated. Use '@port' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq-env.conf.erb]:1
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq-env.conf.erb:1:in `result')
==> default: Warning: Variable access via 'node_ip_address' is deprecated. Use '@node_ip_address' instead. template[/vagrant/modules/rabbitmq/templates/rabbitmq-env.conf.erb]:2
==> default:    (at /vagrant/modules/rabbitmq/templates/rabbitmq-env.conf.erb:2:in `result')
==> default: Warning: Variable access via 'owner' is deprecated. Use '@owner' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:1
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:1:in `result')
==> default: Warning: Variable access via 'nginx_mimes_path' is deprecated. Use '@nginx_mimes_path' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:13
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:13:in `result')
==> default: Warning: Variable access via 'base_read_timeout' is deprecated. Use '@base_read_timeout' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:26
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:26:in `result')
==> default: Warning: Variable access via 'internal_app_ips' is deprecated. Use '@internal_app_ips' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:68
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:68:in `result')
==> default: Warning: Variable access via 'internal_app_ips' is deprecated. Use '@internal_app_ips' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:76
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:76:in `result')
==> default: Warning: Variable access via 'nginx_conf_dir' is deprecated. Use '@nginx_conf_dir' instead. template[/vagrant/modules/nginx/templates/nginx.conf.erb]:85
==> default:    (at /vagrant/modules/nginx/templates/nginx.conf.erb:85:in `result')
==> default: Warning: Variable access via 'syslog_enabled' is deprecated. Use '@syslog_enabled' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:77
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:77:in `result')
==> default: Warning: Variable access via 'db_filename' is deprecated. Use '@db_filename' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:151
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:151:in `result')
==> default: Warning: Variable access via 'working_dir' is deprecated. Use '@working_dir' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:161
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:161:in `result')
==> default: Warning: Variable access via 'slave_of' is deprecated. Use '@slave_of' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:172
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:172:in `result')
==> default: Warning: Variable access via 'eviction_maxmemory' is deprecated. Use '@eviction_maxmemory' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:376
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:376:in `result')
==> default: Warning: Variable access via 'eviction_policy' is deprecated. Use '@eviction_policy' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:404
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:404:in `result')
==> default: Warning: Variable access via 'eviction_samples' is deprecated. Use '@eviction_samples' instead. template[/vagrant/modules/redis/templates/redis.conf.erb]:416
==> default:    (at /vagrant/modules/redis/templates/redis.conf.erb:416:in `result')
==> default: Warning: Variable access via 'ulimit_domain' is deprecated. Use '@ulimit_domain' instead. template[/vagrant/modules/ulimit/templates/rule.conf.erb]:4
==> default:    (at /vagrant/modules/ulimit/templates/rule.conf.erb:4:in `result')
==> default: Warning: Variable access via 'ssl_policy' is deprecated. Use '@ssl_policy' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:1
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:1:in `result')
==> default: Warning: Variable access via 'ssl_policy' is deprecated. Use '@ssl_policy' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:10
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:10:in `result')
==> default: Warning: Variable access via 'server_name' is deprecated. Use '@server_name' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:14
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:14:in `result')
==> default: Warning: Variable access via 'ssl_crt_path' is deprecated. Use '@ssl_crt_path' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:16
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:16:in `result')
==> default: Warning: Variable access via 'ssl_key_path' is deprecated. Use '@ssl_key_path' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:17
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:17:in `result')
==> default: Warning: Variable access via 'app_ui_path' is deprecated. Use '@app_ui_path' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:30
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:30:in `result')
==> default: Warning: Variable access via 'app_ui_path' is deprecated. Use '@app_ui_path' instead. template[/vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb]:37
==> default:    (at /vagrant/modules/nginx/templates/admin_tenant_nginx.conf.erb:37:in `result')

[simong]

Fixed most of the variable access declaration warnings in dec508e

[stuartf]

I fixed the last variable access declaration warning in #115