Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Commit

Permalink
Merge pull request #1 from RitaOak/interface-fixes
Browse files Browse the repository at this point in the history
fix: responsive container scaling for library and groups
  • Loading branch information
RitaOak authored Mar 26, 2020
2 parents 7c3b676 + 0bafc0a commit 1e6c2db
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/components/dashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class OAEDashboard extends PageViewElement {
return html`
<section class="hero is-fullheight">
<div class="hero-body is-fullheight">
<div class="container content-dashboard is-fluid">
<div class="container content-wrapResponsive is-fluid">
<div class="columns dasboard">
<div class="column is-narrow sidebar is-fullheight">
<sidebar-nav2></sidebar-nav2>
Expand Down
14 changes: 7 additions & 7 deletions src/components/groups.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import sharedStyles from '../../style/app.scss';
import groupStyles from '../../style/groups.scss';
import groupButtonStyles from '../../style/groups-filter.scss';
import { PageViewElement } from './page-view-element.js';
import './sidebar.js';
import './top-nav.js';
import './sidebarV2.js';
import './top-navV2.js';
import './groups-feed.js';
import './groups-about.js';
import './news-feed.js';
Expand All @@ -19,17 +19,17 @@ class OAEGroups extends PageViewElement {

render() {
return html`
<section class="hero is-link is-fullheight">
<div class="hero-body">
<div class="container is-fluid is-fullheight is-mobile">
<section class="hero is-fullheight">
<div class="hero-body is-fullheight">
<div class="container content-wrapResponsive is-fluid">
<div class="columns dasboard">
<div class="column is-narrow sidebar">
<sidebar-nav></sidebar-nav>
<sidebar-nav2></sidebar-nav2>
</div>
<div class="column content-base">
<div class=" column content-wrap">
<div class="column top-nav">
<top-nav></top-nav>
<top-nav2></top-nav2>
</div>
<div class=" columns is-flex main-content">
<div class="column is-three-fifths">
Expand Down
14 changes: 7 additions & 7 deletions src/components/library.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import sharedStyles from '../../style/app.scss';
import library from '../../style/library.scss';
import { PageViewElement } from './page-view-element.js';
import '@polymer/iron-icons/iron-icons.js';
import './sidebar.js';
import './top-nav.js';
import './sidebarV2.js';
import './top-navV2.js';
import './info-card.js';
import './tag-card.js';
import './news-feed.js';
Expand All @@ -20,17 +20,17 @@ class OAELibrary extends PageViewElement {

render() {
return html`
<section class="hero is-link is-fullheight">
<div class="hero-body">
<div class="container is-fluid is-fullheight is-mobile">
<section class="hero is-fullheight">
<div class="hero-body is-fullheight">
<div class="container content-wrapResponsive is-fluid">
<div class="columns dasboard">
<div class="column is-narrow sidebar">
<sidebar-nav></sidebar-nav>
<sidebar-nav2></sidebar-nav2>
</div>
<div class="column content-base">
<div class=" column content-wrap">
<div class="column top-nav">
<top-nav></top-nav>
<top-nav2></top-nav2>
</div>
<div class=" columns is-flex main-content">
<div class="column is-four-fifths main-left">
Expand Down
4 changes: 4 additions & 0 deletions style/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ body {
//background-color: #fafafa;
}

.content-wrapResponsive {
position: absolute;
}

.container.is-fluid {
margin: 0;
padding: 0;
Expand Down

2 comments on commit 1e6c2db

@datreeio
Copy link

@datreeio datreeio bot commented on 1e6c2db Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Rules (6 / 6) Passed

👑 Good job! this pull request is aligned with your organization's best practices!

👉 You can review your rules settings at smart policy management 👈

@datreeio
Copy link

@datreeio datreeio bot commented on 1e6c2db Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Rules (6 / 6) Passed

👑 Good job! this pull request is aligned with your organization's best practices!

👉 You can review your rules settings at smart policy management 👈

Please sign in to comment.