Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvmlocal.conf not available when vdsm-tool config-lvm-filter run #277

Open
nirs opened this issue Jul 6, 2022 · 0 comments
Open

lvmlocal.conf not available when vdsm-tool config-lvm-filter run #277

nirs opened this issue Jul 6, 2022 · 0 comments
Labels
bug Issue is a bug or fix for a bug storage

Comments

@nirs
Copy link
Member

nirs commented Jul 6, 2022

/etc/lvm/lvmlocal.conf is installed by vdsm-tool configure --module lvm.
However vdsm-tool config-lvm-filter is run before the configuration phase,
and it run before since we must setup multipath blacklist before configuring
vdsm.

This means that when configuring lvm devices on ovirt < 4.5.1, the option
multipath_wwids_file = "" is not applied, and lvm may fail to add some
devices to the devices file.

  • We don't have a way to fix this in 4.5.1.

  • When upgrading 4.5.1 to 4.5.2 the configuration is already available, no issue.

  • When upgrading from version < 4.5.1 to version >= 4.5.2, we can fix the issue by forcing this option in vdsm-tool --config:

    vgimportdevices --config 'devices { use_devicesfile = 1 multipath_wwids_file = "" filter = ["a|.*|"] }' {vg-name}
    

Another way to fix this is to eliminate vdsm-tool config-lvm-filter and move the
configuration step to vdsm-tool configure --module lvm. But this requires enforcing
order of configurators in vdsm-tool (e.g. lvm runs before multipath), or merging the
storage configurators to one module (storage?).

The ideal order:

  • Install lvm configuration
  • Configure lvm devices (or filter)
  • Configure multipath blacklist
  • Configure multipath
  • Reload multiapth

Related bugs:

@nirs nirs added bug Issue is a bug or fix for a bug storage labels Jul 6, 2022
@nirs nirs added this to the ovirt-4.5.2 milestone Jul 6, 2022
@sandrobonazzola sandrobonazzola removed this from the ovirt-4.5.2 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug or fix for a bug storage
Projects
None yet
Development

No branches or pull requests

2 participants