[engine] Fix problem with follow parameter when api prefix with version removed wrongly #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on removed wrongly Signed-off-by: Stanislav Melnichuk <[email protected]>
sandrobonazzola
requested review from
dupondje
and removed request for
mwperina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
When api requests used with version (e.g. /api/v4) then "follow" parameter brokes processing. All requests have 500 error code in result.
Otherwise without version "follow" parameter works correctly and returns nested entities.
It brokes SDK's when api requests have hard coded api prefix.
I found the reason. When request url processed then api version not considered.
Here is the fix and some tests.
Now request without version and with any api version will work correctly.
Are you the owner of the code you are sending in, or do you have permission of the owner?
yes