Fixed attach disk before create snapshots and other minor bug #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment in disk option "Sparse" when the disk will be created in iSCSI Storage Domain. Fixed get path in call to get_image_chain
nirs
reviewed
Apr 16, 2020
There was a problem hiding this comment.
Thanks for the contribution @fmgb. Please send patch to ovirt gerrit.
See https://ovirt.org/develop/dev-process/working-with-gerrit.html
| @@ -186,6 +186,7 @@ def create_disk(image_info, disk_id, sd_name, disks_service): | |||
| format=types.DiskFormat.RAW, | |||
| provisioned_size=provisioned_size, | |||
| initial_size=initial_size, | |||
| # sparse=False, # In case of iSCSI Storage discomment this. | |||
There was a problem hiding this comment.
sparse=True is valid when using qcow2 format, which is the only format supported
for snapshots.
Only raw=sparse is not supported for block storage domains (FC, iSCSI)
| bootable=False, | ||
| active=True, | ||
| ) | ||
| ) |
| ) | ||
| ) | ||
| # We waited until OK for it when we created the disk. We wait 5s for security | ||
| time.sleep(5) |
There was a problem hiding this comment.
Why is sleep needed? how is it relevant for security?
|
Hi @fmgb, I don't see these changes in our codebase, have they been posted using gerrit, as Ondra has suggesteed? |
|
@fmgb can you please rebase and solve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use this script always I have to execute it twice and attach disk manually. Because the script doesn't attach disk to vm automatically. And when the script tries to create a snapshot, it failed.
Fixed get path in call to get_image_chain
Get path 'disks/' correctly before call get_image_chain.
Added a comment in disk option "Sparse" when the disk will be created in iSCSI Storage Domain.
In iSCSI Storage if the disk is RAW should be Sparse=False.