packaging: setup: Fix configuring grafana with keycloak #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
broken. |
didib
force-pushed
the
fix-grafana-keycloak-already-configured
branch
4 times, most recently
from
ff49817 to
afd8fdb
Compare
sandrobonazzola
force-pushed
the
fix-grafana-keycloak-already-configured
branch
from
afd8fdb to
cdab8bf
Compare
didib
force-pushed
the
fix-grafana-keycloak-already-configured
branch
4 times, most recently
from
12e90e6 to
a207f53
Compare
|
Disable on RHV |
sandrobonazzola
approved these changes
Oct 24, 2022
sandrobonazzola
force-pushed
the
fix-grafana-keycloak-already-configured
branch
from
a207f53 to
9af77a1
Compare
sandrobonazzola
force-pushed
the
fix-grafana-keycloak-already-configured
branch
from
9af77a1 to
6461ad6
Compare
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <[email protected]>
sandrobonazzola
force-pushed
the
fix-grafana-keycloak-already-configured
branch
from
6461ad6 to
748dd37
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this flow:
keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet.
Change-Id: I019335c60f686d139da0e9368147e035db75ba37
Signed-off-by: Yedidyah Bar David [email protected]