Merge pull request #272 from nzzdev/dev

Remove shouldBeBar & -LineChart checks
nzzdev · Feb 7, 2024 · 100b981 · 100b981
2 parents be61e22 + 627a838
commit 100b981
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 112 deletions.
diff --git a/resources/schema.json b/resources/schema.json
@@ -27,7 +27,11 @@
             "type": "ToolEndpoint",
             "config": {
               "endpoint": "notification/logScaleMinValueRequirements",
-              "fields": ["options.chartType", "options.lineChartOptions.yScaleType", "data"]
+              "fields": [
+                "options.chartType",
+                "options.lineChartOptions.yScaleType",
+                "data"
+              ]
             },
             "priority": {
               "type": "high",
@@ -231,36 +235,7 @@
                 "fields": ["data"]
               }
             },
-            "notificationChecks": [
-              {
-                "type": "ToolEndpoint",
-                "config": {
-                  "endpoint": "notification/shouldBeBarChart",
-                  "fields": ["data", "options.chartType"],
-                  "options": {
-                    "limit": 2
-                  }
-                },
-                "priority": {
-                  "type": "medium",
-                  "value": 3
-                }
-              },
-              {
-                "type": "ToolEndpoint",
-                "config": {
-                  "endpoint": "notification/shouldBeLineChart",
-                  "fields": ["data", "options.chartType"],
-                  "options": {
-                    "limit": 40
-                  }
-                },
-                "priority": {
-                  "type": "medium",
-                  "value": 4
-                }
-              }
-            ]
+            "notificationChecks": []
           },
           "default": "Bar"
         },
@@ -688,7 +663,10 @@
                 "type": "ToolEndpoint",
                 "config": {
                   "endpoint": "notification/checkMinValueYAxisLogScale",
-                  "fields": ["options.lineChartOptions.yScaleType", "options.lineChartOptions.minValue"]
+                  "fields": [
+                    "options.lineChartOptions.yScaleType",
+                    "options.lineChartOptions.minValue"
+                  ]
                 },
                 "priority": {
                   "type": "high",

diff --git a/routes/notification/shouldBeBarChart.js b/routes/notification/shouldBeBarChart.js
diff --git a/routes/notification/shouldBeLineChart.js b/routes/notification/shouldBeLineChart.js
diff --git a/routes/routes.js b/routes/routes.js
@@ -14,8 +14,6 @@ module.exports = [
   require("./notification/supportedDateFormat"),
   require("./notification/unsupportedDateFormat"),
   require("./notification/unsupportedDateFormatEvents"),
-  require("./notification/shouldBeBarChart.js"),
-  require("./notification/shouldBeLineChart.js"),
   require("./notification/shouldBeBars.js"),
   require("./notification/tooManyRows.js"),
   require("./locales.js"),