Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item pages PDF viewer: Add "title" to iframe #142

Open
lhenze opened this issue Dec 6, 2021 · 1 comment
Open

Item pages PDF viewer: Add "title" to iframe #142

lhenze opened this issue Dec 6, 2021 · 1 comment
Labels
a11y - significant Accessibility issues -- Must be fixed

Comments

@lhenze
Copy link
Member

lhenze commented Dec 6, 2021

From a11y review:
The frame that contains the PDF of the article on the Individual Results page does not have a name that is easily associated with the content. Add something more descriptive that alerts the screen reader user to the content within the frame. For example:

<iframe title="Article Preview" class="preview-iframe" id="preview-iframe" name="preview-iframe" width="100%" height="400" src="/records/mpp7x-hgg82/preview/Research%20Data%20Management%20Among%20Life%20Sciences%20Faculty.pdf"> </iframe>
@lhenze lhenze added the a11y - significant Accessibility issues -- Must be fixed label Dec 6, 2021
@lhenze
Copy link
Member Author

lhenze commented Dec 6, 2021

PR created: inveniosoftware/invenio-app-rdm#1139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y - significant Accessibility issues -- Must be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lhenze