From 95122bee8657affa39b107269e47f58f80d43fd9 Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Sat, 25 Dec 2021 16:01:26 -0500 Subject: [PATCH 1/2] fix: Fixed an issue with Critical CSS not generating properly out of the box --- buildchain/webpack-configs/critical.config.js | 1 - buildchain/webpack-settings/app.settings.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/buildchain/webpack-configs/critical.config.js b/buildchain/webpack-configs/critical.config.js index f6b00a2..159fe2f 100644 --- a/buildchain/webpack-configs/critical.config.js +++ b/buildchain/webpack-configs/critical.config.js @@ -16,7 +16,6 @@ module.exports = (type = 'modern', settings) => { target: criticalDest, extract: false, inline: false, - minify: true, width: settings.critical.criticalWidth, height: settings.critical.criticalHeight, }) diff --git a/buildchain/webpack-settings/app.settings.js b/buildchain/webpack-settings/app.settings.js index f90668f..c19b548 100644 --- a/buildchain/webpack-settings/app.settings.js +++ b/buildchain/webpack-settings/app.settings.js @@ -25,7 +25,7 @@ module.exports = { dist: path.resolve('../cms/web/dist/'), }, urls: { - criticalCss: 'http://example.test/', + criticalCss: 'http://webpack:8080/', publicPath: () => process.env.PUBLIC_PATH || '/dist/', }, }; From 9ceceb73c0b1c44819b25758ab21d20df7a0250a Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Sat, 25 Dec 2021 16:01:33 -0500 Subject: [PATCH 2/2] chore: Version 2.4.54 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fb5cd4..8de153b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # nystudio107/craft Change Log +## 2.4.54 - 2021.12.25 +### Fixed +* Fixed an issue with Critical CSS not generating properly out of the box + ## 2.4.53 - 2021.12.25 ### Fixed * Fix `node-dev-webpack/Dockerfile` so `npm install` is run