From a72a8249434a3e889a3cfcf766df6955c023eeb4 Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:09:52 -0400 Subject: [PATCH 1/6] refactor: Fix `WORKDIR` so `make craft` etc. commands work as expected --- docker-config/php-prod-craft/Dockerfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docker-config/php-prod-craft/Dockerfile b/docker-config/php-prod-craft/Dockerfile index 6f960dc..f982467 100755 --- a/docker-config/php-prod-craft/Dockerfile +++ b/docker-config/php-prod-craft/Dockerfile @@ -57,12 +57,14 @@ RUN chmod a+x run_queue.sh \ COPY ./composer_install.sh . RUN chmod a+x composer_install.sh +WORKDIR /var/www/project/cms + # Run the composer_install.sh script that will do a `composer install`: # - If `composer.lock` is missing # - If `vendor/` is missing # ...then start up php-fpm. The `run_queue.sh` script in the queue container # will take care of running any pending migrations and apply any Project Config changes, # as well as set permissions via an async CLI process -CMD ./composer_install.sh \ +CMD /var/www/project/composer_install.sh \ && \ php-fpm From 8f1837517d8e094324acce11bc5fb60959901477 Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:11:04 -0400 Subject: [PATCH 2/6] chore: Version 2.5.6 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3eb14c5..1f411aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # nystudio107/craft Change Log +## 2.5.6 - UNRELEASED +### Changed +* Fix `WORKDIR` so `make craft` etc. commands work as expected + ## 2.5.5 - 2022.03.30 ### Changed * Remove deprecated `useProjectConfigFile` from `config/general.php` From 38356cd638bc37cea1de428093e3ab9527c9f49d Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:35:12 -0400 Subject: [PATCH 3/6] refactor: Fix linting issue with `import.meta.hot` --- buildchain/tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/buildchain/tsconfig.json b/buildchain/tsconfig.json index 7f628ad..ca7b401 100644 --- a/buildchain/tsconfig.json +++ b/buildchain/tsconfig.json @@ -25,6 +25,7 @@ "strictFunctionTypes": true, "strictNullChecks": true, "target": "esnext", + "types": ["vite/client"], "typeRoots": [ "node_modules/@types" ] From 9b398fa439ff9d719459035487dff78ed3a1823b Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:35:21 -0400 Subject: [PATCH 4/6] Fix `WORKDIR` in `node-dev-vite` container so `make npm` etc. commands work as expected --- docker-config/node-dev-vite/Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docker-config/node-dev-vite/Dockerfile b/docker-config/node-dev-vite/Dockerfile index 6d8ab2e..3a6c06b 100755 --- a/docker-config/node-dev-vite/Dockerfile +++ b/docker-config/node-dev-vite/Dockerfile @@ -5,6 +5,8 @@ WORKDIR /var/www/project/ COPY ./npm_install.sh . RUN chmod a+x npm_install.sh +WORKDIR /var/www/project/buildchain + # Run our webpack build in debug mode # We'd normally use `npm ci` here, but by using `install`: @@ -16,8 +18,6 @@ RUN chmod a+x npm_install.sh # when working with teams or multiple environments CMD export CPPFLAGS="-DPNG_ARM_NEON_OPT=0" \ && \ - ./npm_install.sh \ - && \ - cd /var/www/project/buildchain/ \ + /var/www/project/npm_install.sh \ && \ npm run dev From 765f272ab90af22a37d9a188ff01cb0328e2fed3 Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:35:30 -0400 Subject: [PATCH 5/6] chore: Version 2.5.6 --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f411aa..810f4d8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,9 @@ ## 2.5.6 - UNRELEASED ### Changed -* Fix `WORKDIR` so `make craft` etc. commands work as expected +* Fix `WORKDIR` in `php-prod-craft` container so `make craft` etc. commands work as expected +* Fix `WORKDIR` in `node-dev-vite` container so `make npm` etc. commands work as expected +* Fix linting issue with `import.meta.hot` ## 2.5.5 - 2022.03.30 ### Changed From 2bbdc8460693a7d99df8a3c1db712cb458b7f2dd Mon Sep 17 00:00:00 2001 From: Andrew Welch Date: Wed, 30 Mar 2022 16:40:01 -0400 Subject: [PATCH 6/6] chore: Version 2.5.6 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 810f4d8..e0f82bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # nystudio107/craft Change Log -## 2.5.6 - UNRELEASED +## 2.5.6 - 2022.03.30 ### Changed * Fix `WORKDIR` in `php-prod-craft` container so `make craft` etc. commands work as expected * Fix `WORKDIR` in `node-dev-vite` container so `make npm` etc. commands work as expected