Use mailroom endpoints to create messages and events during Android syncing #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 455 455
Lines 25056 25022 -34
=========================================
- Hits 25056 25022 -34 ☔ View full report in Codecov by Sentry. |
rowanseymour
changed the title
rowanseymour
force-pushed
the
no_moremsg_queueing
branch
from
0a8e754
to
a497566
Compare
rowanseymour
force-pushed
the
no_moremsg_queueing
branch
from
a497566
to
44d2ddd
Compare
rowanseymour
commented
Apr 1, 2024
| @@ -916,41 +916,6 @@ def test_ignore_android_incoming_msg_invalid_phone(self): | |||
| self.assertIsNotNone(r0) | |||
| self.assertEqual(r0["cmd"], "ack") | |||
|
|
|||
| @mock_mailroom | |||
| def test_inbox_duplication(self, mr_mocks): | |||
There was a problem hiding this comment.
this logic is in mailroom now
rowanseymour
commented
Apr 1, 2024
| @@ -43,6 +45,7 @@ def register(request): | |||
|
|
|||
|
|
|||
| @csrf_exempt | |||
| @transaction.non_atomic_requests | |||
There was a problem hiding this comment.
this is already calling mailroom to make db changes.. so I'm not entirely sure how it's working without this..
norkans7
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for RP to know about queueing contact tasks.. or creating messages/events.
And it doesn't add any new HTTP overhead because we were already calling mailroom
contact/resolveto create such messages/events.