Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting fixes for nwHacks 2024 #388

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

sidyakinian
Copy link
Contributor

@sidyakinian sidyakinian commented Nov 21, 2023

Description

Linting fixes. Some issues were due to components defined not being used, but some of these components were specific to last year (e. g. Livepeer). I commented these out instead of removing them so we can refer to them during development. When nwHacks website is finished, we should consider removing commented out components we won't need.

Other considerations

N/A

Copy link

github-actions bot commented Nov 21, 2023

Visit the preview URL for this PR (updated for commit 155c0ec):

https://dev-nwplus-root--pr388-nwhacks2024-linting-zjhowfyu.web.app

(expires Fri, 01 Dec 2023 23:08:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ca465d4a689cc01bf206252b60f82f45b4ba90eb

@sidyakinian sidyakinian marked this pull request as ready for review November 21, 2023 22:48
Copy link
Member

@meleongg meleongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's been years since we last saw "All Checks Passed" 🫡, thanks for getting this done!

  • made a small change to fix a bug related to the SponsorGrid

@meleongg meleongg merged commit bd958df into nwhacks2024_dev Nov 21, 2023
7 checks passed
@meleongg meleongg deleted the nwhacks2024-linting-fixes branch November 21, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants