Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: write_to_vector_db module contains code specific to Milvus #2085

Open
2 tasks done
efajardo-nv opened this issue Dec 17, 2024 · 0 comments
Open
2 tasks done

[FEA]: write_to_vector_db module contains code specific to Milvus #2085

efajardo-nv opened this issue Dec 17, 2024 · 0 comments
Labels
improvement Improvement to existing functionality

Comments

@efajardo-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

The write_to_vector_db module contains a preprocess_vdb_resources function that uses pymilvus to create schema fields for creating a Milvus collection. This looks like it should instead be in milvus_vector_db_service.py.

Describe your ideal solution

Move code specific to a particular VDB to that VDB's service implementation.

Additional context

This is complicating Kinetica's development of their own Morpheus VDB service because they have their own API for creating collections.
Kinetica vector DB service feature request

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@efajardo-nv efajardo-nv added the feature request New feature or request label Dec 17, 2024
@efajardo-nv efajardo-nv added improvement Improvement to existing functionality and removed feature request New feature or request labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality
Projects
Status: Todo
Development

No branches or pull requests

1 participant