-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: abp_nvsmi_detection
doesn't detect any anomalous rows
#2002
Comments
Results of the
|
|
morpheus-bot-test
bot
moved this from In Progress
to Review - Ready for Review
in Morpheus Boards
Oct 28, 2024
This was referenced Oct 28, 2024
dagardner-nv
added a commit
to dagardner-nv/Morpheus
that referenced
this issue
Oct 29, 2024
rapids-bot bot
pushed a commit
that referenced
this issue
Oct 29, 2024
…2006) Closes #2002 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Christopher Harris (https://github.com/cwharris) URL: #2006
dagardner-nv
added a commit
to dagardner-nv/Morpheus
that referenced
this issue
Oct 29, 2024
github-project-automation
bot
moved this from Review - Ready for Review
to Done
in Morpheus Boards
Oct 29, 2024
rapids-bot bot
pushed a commit
that referenced
this issue
Oct 30, 2024
…e correct rows for each batch (#2015) * `DeserializeStage` now performs a copy of the rows needed for each batch, ensuring each output `ControlMessage` now has a unique `MessageMeta` and underlying `DataFrame` * Works-around issue where calling `SlicedMessageMeta::get_mutable_info().checkout_obj()` returns the entire `DataFrame` * This unfortunately means that `DeserializeStage` will require the GIL. * Remove unused `make_output_message` method * Avoid some redundant code in `SlicedMessageMeta` (unrelated but I was in this part of the code). Closes #2002 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) URL: #2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
24.10
Which installation method(s) does this occur on?
Source
Describe the bug.
24.06 found 188 anomalous rows. I've reproduced this using triton launched from a 24.06 repo, which leads me to believe this is a code issue and not an issue with the model.
Minimum reproducible example
Follow example as documented
examples/abp_nvsmi_detection/README.md
Relevant log output
Click here to see error details
Full env printout
Click here to see environment details
Other/Misc.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: