Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: LLMEngineStage doesn't preserve timestamps when it copies the incoming message #1973

Closed
2 tasks done
dagardner-nv opened this issue Oct 23, 2024 · 0 comments · Fixed by #1975
Closed
2 tasks done

[BUG]: LLMEngineStage doesn't preserve timestamps when it copies the incoming message #1973

dagardner-nv opened this issue Oct 23, 2024 · 0 comments · Fixed by #1975
Assignees
@dagardner-nv
Labels
bug Something isn't working
Milestone
24.10 - Release

Comments

@dagardner-nv
Copy link
Contributor

Version

24.10

Which installation method(s) does this occur on?

Source

Describe the bug.

LLMEngineStage performs a copy of incoming ControlMessages, but fails to copy timestamps

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Oct 23, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 23, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Oct 23, 2024
dagardner-nv added a commit to dagardner-nv/Morpheus that referenced this issue Oct 23, 2024
@dagardner-nv
Add test for issue nv-morpheus#1973. Update the existing test_pipelin…
866b11c 
…e test to run in both CPU & GPU mode
@dagardner-nv dagardner-nv mentioned this issue Oct 23, 2024
Merged
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Oct 23, 2024
@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Oct 23, 2024
rapids-bot bot pushed a commit that referenced this issue Oct 24, 2024
@dagardner-nv
Ensure timestamps are copied in LLMEngineStage (#1975)
e351e07 
Closes #1973

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1975
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
24.10 - Release
Development

Successfully merging a pull request may close this issue.

Ensure timestamps are copied in LLMEngineStage dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv