Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: ci/scripts/gitutils.py::_run_cmd should allow explicitly setting shell=True #1890

Open
2 tasks done
dagardner-nv opened this issue Sep 10, 2024 · 0 comments
Open
2 tasks done
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

Currently the shell argument is determined based upon shell = len(args) <= 0 however there are times when a caller may explicitly need shell to be True, such as using the | pipe operator.

Describe your ideal solution

Expose shell as a function argument or always set it to True

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant