Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: building runtime target fails at git_clone when Morpheus is a submodule #1870

Closed
2 tasks done
ashsong-nv opened this issue Aug 27, 2024 · 1 comment · Fixed by #1914
Closed
2 tasks done

[BUG]: building runtime target fails at git_clone when Morpheus is a submodule #1870

ashsong-nv opened this issue Aug 27, 2024 · 1 comment · Fixed by #1914
Assignees
Labels
bug Something isn't working external This issue was filed by someone outside of the Morpheus team

Comments

@ashsong-nv
Copy link
Contributor

Version

24.10

Which installation method(s) does this occur on?

Docker

Describe the bug.

When trying to build the Morpheus Docker container using the runtime target, the build fails at the git_clone stage.

The relevant line in the error log is the following:

#0 0.570 fatal: not a git repository: /opt/host_repo/../../.git/modules/morpheus

I believe the issue is in Dockerfile lines 298-300. This command does a local clone from an existing cloned morpheus repo located at MORPHEUS_ROOT_HOST using the info in its .git/ directory. However, when morpheus is a submodule, the .git file points to the relative path ../../.git/modules/morpheus, which doesn't get mounted to the container and therefore doesn't exist.

Minimum reproducible example

From within the submodule root:

MORPHEUS_ROOT_HOST=. ./docker/build_container_release.sh

Relevant log output

Click here to see error details
=> ERROR [git_clone 1/1] RUN --mount=type=bind,source=.,target=/opt/host_repo     source activate morpheus &&    git clone file:///opt/host_repo /tmp/morp  0.6s
 => CANCELED [conda_bld_morpheus 3/3] RUN --mount=type=cache,id=workspace_cache,target=/workspace/.cache,sharing=locked     --mount=type=cache,id=conda_pkg  0.4s
------                                                                                                                                                            
 > [git_clone 1/1] RUN --mount=type=bind,source=.,target=/opt/host_repo     source activate morpheus &&    git clone file:///opt/host_repo /tmp/morpheus_repo &&    cd /tmp/morpheus_repo &&    git lfs install &&    /tmp/morpheus_repo/scripts/fetch_data.py fetch datasets examples:
#0 0.565 Cloning into '/tmp/morpheus_repo'...
#0 0.570 fatal: not a git repository: /opt/host_repo/../../.git/modules/morpheus
#0 0.571 fatal: Could not read from remote repository.
#0 0.571 
#0 0.571 Please make sure you have the correct access rights
#0 0.571 and the repository exists.
------
Dockerfile:298
--------------------
 297 |     # Source the morpheus env to pick up the git-lfs package
 298 | >>> RUN --mount=type=bind,source=${MORPHEUS_ROOT_HOST},target=/opt/host_repo \
 299 | >>>     source activate morpheus &&\
 300 | >>>     git clone file:///opt/host_repo /tmp/morpheus_repo &&\
 301 | >>>     cd /tmp/morpheus_repo &&\
 302 | >>>     git lfs install &&\
 303 | >>>     /tmp/morpheus_repo/scripts/fetch_data.py fetch datasets examples
 304 |     
--------------------
ERROR: failed to solve: process "/bin/bash -c source activate morpheus &&    git clone file:///opt/host_repo /tmp/morpheus_repo &&    cd /tmp/morpheus_repo &&    git lfs install &&    /tmp/morpheus_repo/scripts/fetch_data.py fetch datasets examples" did not complete successfully: exit code: 128

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

Relevant PR and comment:

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@ashsong-nv ashsong-nv added the bug Something isn't working label Aug 27, 2024
@morpheus-bot-test morpheus-bot-test bot added the Needs Triage Need team to review and classify label Aug 27, 2024
@morpheus-bot-test
Copy link

Hi @ashsong-nv!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the meantime, feel free to add any relevant information to this issue.

@morpheus-bot-test morpheus-bot-test bot added the external This issue was filed by someone outside of the Morpheus team label Aug 27, 2024
@dagardner-nv dagardner-nv self-assigned this Sep 26, 2024
@dagardner-nv dagardner-nv removed the Needs Triage Need team to review and classify label Sep 26, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Sep 26, 2024
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Sep 26, 2024
@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Sep 26, 2024
@rapids-bot rapids-bot bot closed this as completed in 56c57f1 Sep 27, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external This issue was filed by someone outside of the Morpheus team
Projects
Status: Done
3 participants