Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up implementations of LLM Service #1733

Open
8 tasks
mdemoret-nv opened this issue Jun 12, 2024 · 0 comments
Open
8 tasks

Clean up implementations of LLM Service #1733

mdemoret-nv opened this issue Jun 12, 2024 · 0 comments
Labels
improvement Improvement to existing functionality

Comments

@mdemoret-nv
Copy link
Contributor

The LLM Service wrappers have evolved over time and need to be cleaned up to be uniform. The following items should be examined and updated to be uniform across the 3 implementations: "openai", "nvfoundation", "nemo". If any other types have been added, they should be cleaned up as well.

  • Services should handle environment variables using the new EnvConfigValue class
  • All arguments for common methods should use similar names
  • All docstrings should be similar and accurate
  • Tests for these wrappers should be similar and laid out consistently
    • Only one test file per service (remove any service/client separate test files)
    • Tests should exercise creation of the class via the LLMService.create function
  • Test methods should be arranged in a similar order
  • Each service should be used in the tests/llm/test_*_pipe.py tests
@mdemoret-nv mdemoret-nv added the improvement Improvement to existing functionality label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality
Projects
Status: Todo
Development

No branches or pull requests

1 participant