Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary input parameter used #1693

Closed
ylnhari opened this issue May 8, 2024 · 1 comment · Fixed by #1700
Closed

Unnecessary input parameter used #1693

ylnhari opened this issue May 8, 2024 · 1 comment · Fixed by #1700

Comments

@ylnhari
Copy link

ylnhari commented May 8, 2024

https://github.com/nv-morpheus/Morpheus/blob/c88527bee55a4e6b634e9a553d4a581a128e05a5/examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_inference.py#L100C28-L100C39

What is the purpose of including the 'client' parameter while calling this method when it doesn't appear to be utilized within the method's implementation?
@efajardo-nv
Copy link
Contributor

Thanks @ylnhari. You are correct. The client parameter is not used. We'll remove it from both the module and stage implementation.

@efajardo-nv efajardo-nv mentioned this issue May 14, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue May 15, 2024
@efajardo-nv
Remove unused MLflow client arg from DFP inference implementations (#…
b61502a 
…1700)

- Remove unused MLflow client arg from DFP inference stage and module implementations
- Add missing table of content items to Modular DFP guide

Closes #1693 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1700
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused MLflow client arg from DFP inference implementations efajardo-nv/Morpheus
2 participants
@ylnhari @efajardo-nv