Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: filter_null arg to FileSourceStage ignored by C++ impl #1678

Closed
2 tasks done
dagardner-nv opened this issue May 2, 2024 · 0 comments · Fixed by #1689
Closed
2 tasks done

[BUG]: filter_null arg to FileSourceStage ignored by C++ impl #1678

dagardner-nv opened this issue May 2, 2024 · 0 comments · Fixed by #1689
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.06

Which installation method(s) does this occur on?

Source

Describe the bug.

This is only supported on the Python side. Should be easy enough to implement it in C++ or make it a Python mrc node

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label May 2, 2024
@dagardner-nv dagardner-nv self-assigned this May 3, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards May 3, 2024
@dagardner-nv dagardner-nv mentioned this issue May 6, 2024
Merged
@dagardner-nv dagardner-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards May 7, 2024
@rapids-bot rapids-bot bot closed this as completed in #1689 May 9, 2024
rapids-bot bot pushed a commit that referenced this issue May 9, 2024
@dagardner-nv
Support the filter_null parameter in the C++ impl of the FileSourceSt…
bf80d93 
…age (#1689)

* Fixes bug where the `filter_null` constructor argument to the `FileSourceStage` was only implemented in the Python impl of the stage.
* Update `filter_null` feature to make the column(s) being filtered upon configurable, previously this was hard-coded to `"data"`
* Add new `get_column_names` helper method to `CuDFTableUtil`

Closes #1678

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1689
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support the filter_null parameter in the C++ impl of the FileSourceStage dagardner-nv/Morpheus
1 participant
@dagardner-nv