Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Support force_convert_inputs in C++ impl of Triton stage #1673

Closed
2 tasks done
dagardner-nv opened this issue Apr 30, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.06

Which installation method(s) does this occur on?

Source

Describe the bug.

Currently the Python impl supports force_convert_inputs and use_shared_memory as constructor args, but disregards these values in C++ mode without warning the user.

Ideally we should support these in C++, and if not fall-back to the Python impl

Minimum reproducible example

No response

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Apr 30, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 30, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Apr 30, 2024
@dagardner-nv
Copy link
Contributor Author

It looks like the C++ stage does implicitly cast types.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Morpheus Boards May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant