Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC]: Update examples to run from project root #1671

Closed
2 tasks done
dagardner-nv opened this issue Apr 29, 2024 · 0 comments · Fixed by #1674
Closed
2 tasks done

[DOC]: Update examples to run from project root #1671

dagardner-nv opened this issue Apr 29, 2024 · 0 comments · Fixed by #1674
Assignees
@dagardner-nv
Labels
doc Improvements or additions to documentation

Comments

@dagardner-nv
Copy link
Contributor

How would you describe the priority of this documentation request

Low (would be nice)

Please provide a link or source to the relevant docs

examples/README.md

Describe the problems in the documentation

This would make it easier when performing manual testing of running examples

(Optional) Propose a correction

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the doc Improvements or additions to documentation label Apr 29, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 29, 2024
@dagardner-nv dagardner-nv mentioned this issue May 1, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in #1674 May 2, 2024
rapids-bot bot pushed a commit that referenced this issue May 2, 2024
@dagardner-nv
Update examples to execute from the root of the repo (#1674)
808c52c 
* Update top-level examples and Triton start-up commands to execute from the root of the repo
* Where possible set default values for cli flags, removing the need to set them for the common use-case
* Where possible remove the need for defining `MORPHEUS_ROOT`
* Ensure C++ Triton pipelines use port 8000 to avoid the warning about the grpc port.
* Optionally cast types in the C++ impl of the Triton stage when `force_convert_inputs=true` and the input and model types didn't match (previously types were always casted)
* Remove `--num_threads=1` restriction and configure logging for the `log_parsing` example
* Remove `--num_threads=8` restriction from `nlp_si_detection` since the pipeline has more than 8 stages.
* Don't invoke the C++ impl of preallocate if the type being requested isn't supported on the C++ side (strings)
* Don't use the C++ impl of the Triton stage if `use_shared_memory` is requested as this isn't supported in C++.
* Add missing `gnn-fraud-classification` stage to CLI alternative for `gnn_fraud_detection_pipeline` example

Closes #1671

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Eli Fajardo (https://github.com/efajardo-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1674
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update examples to execute from the root of the repo dagardner-nv/Morpheus
1 participant
@dagardner-nv